Skip to content

Fix: support for docker 26+ #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2024
Merged

Fix: support for docker 26+ #118

merged 1 commit into from
Jun 2, 2024

Conversation

xtrime-ru
Copy link
Contributor

@xtrime-ru xtrime-ru commented May 14, 2024 •
edited
Loading

In docker 26 /etc/resolv.conf in containers with bridge network was updated.

docker v25:

nameserver 127.0.0.11
options edns0 trust-ad ndots:0

in docker 26+:

# Generated by Docker Engine.
# This file can be edited; Docker Engine will not make further changes once it
# has been modified.

nameserver 127.0.0.11
search .
options edns0 trust-ad ndots:0

# Based on host file: '/etc/resolv.conf' (internal resolver)
# ExtServers: [1.1.1.1 127.0.0.1]

# Overrides: [nameservers]
# Option ndots from: internal

Additional line search . was added.
This causes internal docker domains like "mysql" to resolve like "mysql..." in amp/dns, which is wrong.

@xtrime-ru xtrime-ru force-pushed the 2.x branch 2 times, most recently from 2a70849 to 795f48d Compare May 14, 2024 17:00
@xtrime-ru xtrime-ru mentioned this pull request May 15, 2024
Closed
@kelunik kelunik merged commit 089f445 into amphp:2.x Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xtrime-ru @kelunik