Make implicit nullable types explicit #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is this an improvement? |
|
@Bilge It will fix the deprecations of https://wiki.php.net/rfc/deprecate-implicitly-nullable-types in PHP 8.4. |
|
@nicolas-grekas We sadly cannot trivially merge that into 1.x currently as the minimum supported version for the 1.x branch is 7.0, which doesn't know about nullable types. I'm not sure what the best way forward here is. |
kelunik
approved these changes
Mar 20, 2024
|
Just increase the minimum supported version. Doing so does not require a new major. |
|
@nicolas-grekas Thanks! @bwoebi The way forward is quite obvious: Increase the minimum version to 7.1 as we did in most libraries already, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch 1.x is the one we can use with Symfony HttpClient at the moment