feat(glazewm_binding_mode): cycling through modes, default_icon option, icons option, improved css classes
#276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e84599c to
c71680e
Compare
|
Can you clean up the commit history before the merge? |
|
Yep i will do that when i get to a computer, should i keep 2 commits only? |
…-offline` css class, better icon handling
…-offline` css class, better icon handling This commit implements multiple improvements to the GlazeWM Binding Mode Widget.
c71680e to
a2c998f
Compare
|
I did the cleaning up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements multiple new features to improve the usage of the binding mode widget.
Cycling through modes
next_binding_modeandprev_binding_mode, with these the user can cycle through workspaces in order that is given in thebinding_modes_to_cycle_throughoption. Example for thebinding_modes_to_cycle_throughoption:['none', 'resize', 'pause']Icons improvement
iconsoption enables user to specify an icon for each binding mode based on the name of the mode.{'pause' : '\uf28c'}default_iconoption is used for the modes where the user didn't specify an iconCSS improvement