Skip to content

Conversation

trimclain
Copy link
Contributor

@trimclain trimclain commented May 8, 2025

PR #249 added labels active_populated and active_empty, however the CSS classes for them were not implemented. This PR adds missing classes, removes obsolete ones and updates the docs.

BREAKING CHANGE: replace .glazewm-workspaces .ws-btn.active with .glazewm-workspaces .ws-btn.active_populated in styles.css

PR amnweb#249 added labels `active_populated` and `active_empty`,
however the CSS classes for them for not updated.
This commit adds missing classes and removes obsolete ones.
@trimclain trimclain force-pushed the update-glazewm-workspace-css branch from bf3adea to 5e1705b Compare May 8, 2025 15:17
- Add `.active_populated` and `.active_empty` classes instead of `.active`
- Fix examples with `.btn` instead of `.ws-btn`
- Fix markdown table formatting
@trimclain trimclain force-pushed the update-glazewm-workspace-css branch from 5e1705b to 0195b7c Compare May 8, 2025 15:19
Copy link
Contributor

@Video-Nomad Video-Nomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will break styles for people but since we added extra state for label, it makes sense to add the style too.

@trimclain trimclain changed the title feat(glazewm): add css classes active_populated and active_empty feat!(glazewm): add css classes active_populated and active_empty May 8, 2025
@trimclain trimclain changed the title feat!(glazewm): add css classes active_populated and active_empty feat(glazewm)!: add css classes active_populated and active_empty May 8, 2025
@amnweb amnweb merged commit a5fb779 into amnweb:main May 8, 2025
@trimclain trimclain deleted the update-glazewm-workspace-css branch May 12, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants