Skip to content

Conversation

szbmrk
Copy link
Contributor

@szbmrk szbmrk commented May 4, 2025

Purpose

This widget shows the active binding mode for GlazeWM, so that the user can see if they are in for example Resize or Pause binding modes. With callbacks the user can disable the current binding mode as well.

Concern

The GlazeWM websocket gives back a list of bindingMode when the binding mode is changed but as i tried it if i have a binding mode active and i want to activate another one the first one disables thus always resulting in no active binding modes or only one. And i haven't seen a config where anyone would use two or more binding modes at once. Therefore i implemented the widget to handle the first element of the given list. So i think it solves the concern but i can implement the widget to handle all the list elements as well if needed.

Preview of widget

glazewm_binding_mode_widget

@Video-Nomad
Copy link
Contributor

Video-Nomad commented May 4, 2025

Please rebase/squash some of those commits especially that merge one. Ideally leave only two: docs and feat as they are the ones relevant.

@szbmrk
Copy link
Contributor Author

szbmrk commented May 4, 2025

I'm new to contributing to open-source and using git like this, can you tell me how to do that please?

@Video-Nomad
Copy link
Contributor

Video-Nomad commented May 4, 2025

If you are using GitHub Desktop just select those commits and right click - squash. It will allow you to edit the commit messages and in the end you will have only one commit with the new message.

If you are using git cli it will be git rebase upstream/main or interactive rebase git rebase -i HEAD~4 (or however many commits you want to squash). It will open your default git editor and you can then replace "pick" with squash on the commits you want to squash together.

I recommend you to use GitHub Desktop though if you are new to git.

@Video-Nomad
Copy link
Contributor

And after that when everything is good git push -f

@Video-Nomad
Copy link
Contributor

Thanks!

@Video-Nomad
Copy link
Contributor

Looks good to me. Tested and it seems to be working as expected.

@amnweb amnweb merged commit 84ad779 into amnweb:main May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants