Allow for use of a different primary key #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to bugs in some versions of activerecord, resetting the column information doesn't always work, unless the schema cache is cleared.
a0713e2 to
e675cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where external tree-based data is cached or otherwise held locally, the ids used by the external service can differ from the database's primary key.
This picks up the work done by @Two9A but adds an additional commit on top to work around bugs with
ActiveRecord::Base.reset_column_information, which appears to be ineffective in both activerecord 3.2 and 4.1, which lead to test failures due to the column cache not being invalidated.Closes #50.