Skip to content

Conversation

wtgtybhertgeghgtwtg
Copy link
Collaborator

Proposed to close #87.

@amasad
Copy link
Owner

amasad commented Feb 13, 2017

According to the example repo the rootDir is invalid. If you swallow the error, sane is a no-op and the user -- who potentially by mistake passed the wrong path -- will never know about the error.

I think this should be solved by the caller. Just do fs.stat, make sure it exists, and is a directory and don't call sane if it's not.

@amasad
Copy link
Owner

amasad commented Feb 13, 2017

I commented on your watchpack PR with suggestions. Closing but open to discuss this.

@amasad amasad closed this Feb 13, 2017
@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg deleted the wrap-fs.watch branch February 13, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not throw on missing directory/file.
2 participants