Add ignore option to NodeWatcher #50
Conversation
|
My concern with this is that it's only implemented at the initialization phase. Imagine if an ignored Also, a test would be fantastic 👍 |
|
I moved the logic to Also add a couple of simple tests |
|
so, i think to add such a feature it should attempt to use the best possible ignore across all watchers. Watchman for example, has a low level ignore that is significantly more performant then doing it in JS. Currently, I am unsure if this is configurable via the JS API. But it is configurable via |
|
closed via #79 |
Add the simplest possible implementation of ignore option that allows not to watch directories that match
the given glob(s).
Added to allow to ignore the
node_modulesfolder of React Native. It was causing an EMFILE error because it'd exceed the allowed number of open file descriptors on Travis CI.Right now it was just implemented on
NodeWatcherbut I can add it to the other watchers if you think it's useful/necessary.It currently supports:
new NodeWatcher('path/to/project', { ignore: 'node_modules' })new NodeWatcher('path/to/project', { ignore: ['a', 'b', 'c'] })