Pin Spanner pgadapter-emulator to v0.48.3 #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change to the [Google Cloud Spanner PGAdapter and Spanner Emulator][1] in v0.48.4 is breaking our `dbmate` test. [1]: https://github.com/GoogleCloudPlatform/pgadapter?tab=readme-ov-file#emulator Our tests did not pin to a particular version, resulting in our tests starting to fail with no change to dbmate. ```shell go test -v -p 1 -tags netgo,osusergo,sqlite_omit_load_extension,sqlite_fts5,sqlite_json -ldflags '-s -extldflags "-static"' -run TestSpannerPostgresCreateMigrationsTable ./pkg/driver/postgres # ./... === RUN TestSpannerPostgresCreateMigrationsTable === RUN TestSpannerPostgresCreateMigrationsTable/default_schema postgres_test.go:83: Error Trace: /src/pkg/driver/postgres/postgres_test.go:83 /src/pkg/driver/postgres/postgres_test.go:451 Error: Received unexpected error: pq: NOT_FOUND: io.grpc.StatusRuntimeException: NOT_FOUND: Input file third_party/spanner_pg/catalog/proto/functions.txtpb not opened successfully. - Statement: 'select option_value from information_schema.database_options where option_name='database_dialect'' Test: TestSpannerPostgresCreateMigrationsTable/default_schema --- FAIL: TestSpannerPostgresCreateMigrationsTable (0.04s) --- FAIL: TestSpannerPostgresCreateMigrationsTable/default_schema (0.04s) FAIL FAIL github.com/amacneil/dbmate/v2/pkg/driver/postgres 0.046s FAIL make: *** [Makefile:43: test] Error 1 ``` Our tests were passing up until version v0.48.3. ```shell go test -v -p 1 -tags netgo,osusergo,sqlite_omit_load_extension,sqlite_fts5,sqlite_json -ldflags '-s -extldflags "-static"' -run TestSpannerPostgresCreateMigrationsTable ./pkg/driver/postgres # ./... === RUN TestSpannerPostgresCreateMigrationsTable === RUN TestSpannerPostgresCreateMigrationsTable/default_schema --- PASS: TestSpannerPostgresCreateMigrationsTable (2.12s) --- PASS: TestSpannerPostgresCreateMigrationsTable/default_schema (2.12s) PASS ok github.com/amacneil/dbmate/v2/pkg/driver/postgres 2.123s ``` As this appears to be a failure introduced in the upstream emulator, let's pin our tests to version v0.48.3 for now.
|
Spanner Postgres interface support #555 |
amacneil
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to the Google Cloud Spanner PGAdapter and Spanner Emulator in v0.48.4 is breaking our
dbmatetest.Our tests did not pin to a particular version, resulting in our tests starting to fail with no change to dbmate.
Our tests were passing up until version v0.48.3.
As this appears to be a failure introduced in the upstream emulator, let's pin our tests to version v0.48.3 for now.