Replace bell icon with settings icon #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bell icon was misleading since clicking it opens a unified settings dialog containing: - Notification preferences - General app settings (keyboard mode, log links, repository path) Changed to a gear/cog icon which better represents the button's purpose while maintaining the color-coded notification status (green when enabled, red when disabled). Fixes #364
Changed the settings icon to use the default muted color (instead of red) when notifications are disabled. Only shows green when notifications are actively enabled. This provides a less alarming appearance while still indicating notification status.
🔍 Code Quality ReportThis comment is automatically updated with linting results from CI. Node.js Biome Formatting ✅ Status: PassedNode.js Biome Linting ✅ Status: PassedNode.js Test Coverage ✅ Status: PassedClient Coverage: Server Coverage: Mac Formatting (SwiftFormat) ❌ Status: FailedClick to see detailsMac Linting (SwiftLint) ✅ Status: PassedmacOS Test Coverage ❌ Status: Failed• Coverage: 0% |
There was a problem hiding this comment.
Bug: Notification Icon Color Mismatch
The notification status icon's color for disabled states was changed from red (text-status-error) to gray (text-muted). This contradicts the PR description's claim of maintaining red for disabled notifications, creating a discrepancy between documented and actual behavior.
web/src/client/components/notification-status.ts#L88-L89
vibetunnel/web/src/client/components/notification-status.ts
Lines 88 to 89 in 422ad4c
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
Claude finished @steipete's task —— View job 📋 SummaryThis PR replaces the bell icon with a settings gear icon in the notification-status component and updates tooltips to clarify that the button opens general settings rather than just notification preferences. The changes better reflect the button's actual functionality since it opens a unified settings dialog containing multiple configuration options. ✅ Positive Aspects
🔍 Areas for ImprovementCode Quality
Potential Issues
Performance
Security
Testing
💡 Suggestions
🎯 Priority Items
Reviewed commit: 422ad4c Todo List:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why
The bell icon was misleading since clicking it opens a unified settings dialog that contains much more than just notification preferences:
A settings/gear icon better represents the button's actual functionality.
Changes
Test Plan
Fixes #364