Implementation Plan

I've created a comprehensive implementation plan for fixing screen capture authentication across all auth modes. The issue is that screen capture currently only works when authentication is disabled, which is a critical security limitation.

Root Cause:

Screen capture WebSocket/HTTP endpoints not properly authenticated
Missing auth headers in screen capture requests
WebSocket upgrade not handling auth tokens
Session validation not applied to screen capture streams

Solution Overview:

Enhanced Authentication Middleware - Properly authenticate both HTTP and WebSocket connections
Auth Provider Updates - Fix Token, Tailscale, and OAuth providers for screen share
Client-Side Auth - Update client to send auth tokens with WebSocket connections
Permission System - Add granular permissions for screen sharing
Security Hardening - Rate limiting and session management

Key Implementation Details:

WebSocket auth via query parameters (for browser compatibility)
Fallback auth methods for different scenarios
Support for all auth modes (None, Token, Tailscale, OAuth)
Proper permission validation before allowing screen share
Comprehensive error handling and user feedback

This fix will allow screen sharing to work securely in production environments with authentication enabled.

Full implementation details are available in:

Screencap doesn't worth with auth modes other than none. #264

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions