helm-org-ql shows no results #179
Description
I'm pretty sure helm-org-ql isn't working on master. I ran into the issue with some of my own code that I shamelessly lifted from you 😛
Basically, helm-org-ql--heading returns a cons cell: https://github.com/alphapapa/org-ql/blob/master/helm-org-ql.el#L217
This then get incorrectly flattened in org-ql-select: https://github.com/alphapapa/org-ql/blob/master/org-ql.el#L272
This produces an error like (wrong-type-argument listp #<marker at 77113 in some-org-file.org>) that gets swallowed by the ignore-errors here: https://github.com/alphapapa/org-ql/blob/master/helm-org-ql.el#L187
I tested this with the following init.el:
(setq user-init-file (or load-file-name (buffer-file-name)))
(setq user-emacs-directory (file-name-directory user-init-file))
(require 'package)
(add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/") t)
(setq package-enable-at-startup nil)
(package-initialize)
(when (not package-archive-contents)
(package-refresh-contents))
(defvar bootstrap-version)
(let ((bootstrap-file
(expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
(bootstrap-version 5))
(unless (file-exists-p bootstrap-file)
(with-current-buffer
(url-retrieve-synchronously
"https://raw.githubusercontent.com/raxod502/straight.el/develop/install.el"
'silent 'inhibit-cookies)
(goto-char (point-max))
(eval-print-last-sexp)))
(load bootstrap-file nil 'nomessage))
(straight-use-package 'use-package)
(use-package helm
:straight t)
(use-package org-ql
:straight t)
(use-package helm-org-ql
:straight t)And then running M-x helm-org-ql-org-directory.
In my own code, I worked around this by changing the return type of helm-org-ql--heading to be a text object, setting the point-marker as a text property and then turning it back into a cons cell inside the helm-org-ql-source candidate function: landakram/org-z@8f32cb4#diff-45a6113f0a5362216add4458e26c4de186589ee9168a3b4691dcef5255b759a6L191
Happy to make a PR here if that direction sounds good to you.