Skip to content

magit-todos-section-map hides the "j" keybinding expected in the status buffer #143

@ghost

Description

Hello,

I found that when using the jump command anywhere in the magit-status buffer, the transient menu was displayed as expected with the "T" and "l" options properly added after ed4f5c4.

image

However inside the todo section I don't get a transient menu when pressing "j" and only have "T" and "l" available as options :

image

The following patch seems to fix the issue :

image

---
 magit-todos.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/magit-todos.el b/magit-todos.el
index 0823ac9..158ff16 100644
--- a/magit-todos.el
+++ b/magit-todos.el
@@ -119,8 +119,7 @@ magit-status buffer.")
 
 (defvar magit-todos-section-map
   (let ((map (make-sparse-keymap)))
-    (define-key map "jT" #'magit-todos-jump-to-todos)
-    (define-key map "jl" #'magit-todos-list)
+    (set-keymap-parent map magit-status-mode-map)
     (define-key map "b" #'magit-todos-branch-list-toggle)
     (define-key map "B" #'magit-todos-branch-list-set-commit)
     (define-key map [remap magit-visit-thing] #'magit-todos-list)

base-commit: 7724259a008144b8cfc6cacdae3e764f207a03e7
-- 

EDIT: I should have mentioned I'm running emacs 30 and magit-todos version 1.6 (from melpa).

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions