fix: remove subdirectory paths from test_new.diff #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When test_proces_diff processes this file, it fails to create the subdirectories, leading to test failure. Since the subdirectories aren't really needed, removing them allows the test to complete successfully. Updated number of expected passing tests to account for the additional tests which can run to completion now.
|
@alstr, I think it's really important that the |
Agreed, it was just a temporary fix to prevent the tests failing in the meantime. We will just need to bear in mind that any future additions will need to follow this format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When test_proces_diff processes
test_new.diff, it creates the files that are referenced by the diff. If a file path contains a subdirectory, it fails to actually create the file, which in turn causes the test to fail. This PR cleans uptest_new.diffsuch that no file is referenced within a subdirectory.Updated number of expected passing tests to account for the additional tests which can run successfully now.
This is related to #266 and resolves the lingering issues that are referenced in comments there.