Skip to content

fix unbound qkv #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix unbound qkv #711

merged 2 commits into from
Aug 22, 2024

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Aug 22, 2024

No description provided.

@epwalsh epwalsh requested a review from chrisc36 August 22, 2024 17:02
chrisc36
chrisc36 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@chrisc36 chrisc36 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look fine. A non-essential nitpick is that variable is still a hidden state, not qkv, so I would have preference to rename it as well.

@epwalsh
Copy link
Member Author

epwalsh commented Aug 22, 2024

@chrisc36 done

@epwalsh epwalsh merged commit 213a639 into main Aug 22, 2024
9 of 11 checks passed
@epwalsh epwalsh deleted the epwalsh/fix-unbound-qkv branch August 22, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisc36 chrisc36 chrisc36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epwalsh @chrisc36