Change naming convention for HF checkpoints. #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `hf_olmo` instead of `old_style` and `transformers` for `new_style`. Add docstring explaining the difference and default to using `hf_olmo`, which is standard for internal development.
2015aroras
approved these changes
Aug 16, 2024
| @@ -111,7 +124,7 @@ def s3_unshard_to_hf(args): | |||
|
|
|||
| # Convert to HF. | |||
| print("Converting to HF.") | |||
| if args.old_style_hf: | |||
| if args.checkpoint_style == "hf_olmo": | |||
| # Convert to old-style checkpoint. | |||
There was a problem hiding this comment.
nit: update the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
hf_olmoinstead ofold_styleandtransformersfornew_style. Add docstring explaining the difference and default to usinghf_olmo, which is standard for internal development.I've run this and it seems to work fine.