Read and use tokenizer identifier from config #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
reviewed
Jun 10, 2024
Comment on lines
+206
to
+213
| config_path = Path(checkpoint_dir) / "config.yaml" | ||
| tokenizer_config = yaml.safe_load(config_path.read_text())["tokenizer"] | ||
|
|
||
| # Initialize tokenizer and validate vocab size. | ||
| if Path(tokenizer_config["identifier"]).is_file(): | ||
| base_tokenizer = Tokenizer.from_file(tokenizer_config["identifier"]) | ||
| else: | ||
| base_tokenizer = Tokenizer.from_pretrained(tokenizer_config["identifier"]) |
There was a problem hiding this comment.
Any reason not to do this:
Suggested change
| config_path = Path(checkpoint_dir) / "config.yaml" | |
| tokenizer_config = yaml.safe_load(config_path.read_text())["tokenizer"] | |
| # Initialize tokenizer and validate vocab size. | |
| if Path(tokenizer_config["identifier"]).is_file(): | |
| base_tokenizer = Tokenizer.from_file(tokenizer_config["identifier"]) | |
| else: | |
| base_tokenizer = Tokenizer.from_pretrained(tokenizer_config["identifier"]) | |
| base_tokenizer = Tokenizer.from_checkpoint(checkpoint_dir) |
There was a problem hiding this comment.
This is Tokenizer from the tokenizers library, not the one from the OLMo code base. I made my first PR not remembering this.
epwalsh
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction of #610, tested on a 1.7 7B checkpoint.