Add scheduler for cosine in linear envelope. #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This didn't prove particularly effective for annealing, but might as well have it as an option.
2015aroras
reviewed
Aug 6, 2024
olmo/optim.py
Outdated
| t_max: Optional[int] = None | ||
|
|
||
| def get_lr(self, initial_lr: float, step: int, max_steps: int) -> float: | ||
| eta_min = 0.0 |
There was a problem hiding this comment.
Consider setting this to initial_lr * alpha_f, like with the cosine and linear schedulers. Warm up would probably be nice too.
There was a problem hiding this comment.
If you use alpha_f, you may need to update the logic for computing the envelope.
There was a problem hiding this comment.
Changed, lmk if this looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't prove particularly effective for annealing, but might as well have it as an option.