Skip to content

sharded ckpt is saved only for fsdp #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

sharded ckpt is saved only for fsdp #665

merged 1 commit into from
Jul 17, 2024

Conversation

ananyahjha93
Copy link
Contributor

Fixes #664 .

@ananyahjha93 ananyahjha93 requested a review from epwalsh July 17, 2024 08:36
@ananyahjha93 ananyahjha93 merged commit d627c94 into main Jul 17, 2024
10 of 12 checks passed
@ananyahjha93 ananyahjha93 deleted the ddp-ckpt-fix branch July 17, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epwalsh epwalsh epwalsh approved these changes

@2015aroras 2015aroras 2015aroras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DDP training tries to save sharded checkpoint on the last step
3 participants
@ananyahjha93 @epwalsh @2015aroras