Firehose Logging #480
Merged
Firehose Logging #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
approved these changes
Mar 4, 2024
olmo/util.py
Outdated
| @@ -59,6 +59,7 @@ def __repr__(self) -> str: | |||
| class LogFilterType(StrEnum): | |||
| rank0_only = "rank0_only" | |||
| local_rank0_only = "local_rank0_only" | |||
| firehose = "firehose" | |||
There was a problem hiding this comment.
I don't have a strong opinion here but maybe "all_ranks" instead of "firehose" to be more consistent with the existing names?
2015aroras
approved these changes
Mar 5, 2024
|
Tests fail because of a version conflict with cached_path. Cached_path can't be updated because of the script that parses the changelog. Looks like AGI has to wait another day. |
|
Oyvind has a fix in this PR: #484 |
This is true, but the underlying issue is an unnecessary pin in cached_path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.