feat(pool): add non-blocking submission methods and dropped tasks metric #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 95.27% 95.47% +0.20%
==========================================
Files 11 11
Lines 720 752 +32
==========================================
+ Hits 686 718 +32
Misses 31 31
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TrySubmitandTrySubmitErr). This feature was requested in Should always expose aTrySubmitmethod (v2) #103DroppedTasksmetric that reflects the number of tasks that were not executed because the queue was full. Issue reported in Non-blocking pool does not show correct FailedTasks and other counters when queue is full #100SubmittedTasksmetric now includes dropped tasks and it stops being updated once the pool is stopped.