-
-
Notifications
You must be signed in to change notification settings - Fork 57
Specify the initial branch for test repos. #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reason: the git in macOS Xcode 14 defaults the initial branch to 'main', but the tests assume 'master'. * testsuite/drivers/helpers.py (init_git_repo): check out the branch 'master'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch @simonjwright !
Can we do the opposite and always use main
instead of master
?
@Fabien-Chouteau Since not all gits have the same default, or the same way of specifying the default, I think we have to choose something and set it. Might as well be |
Oh. My tests ran on macOS 11.7 with Xcode 13.2.1, yours ran on 12.6 (which is the version I run on here) and Xcode 14.0.1 (I’m running 14.1.0). Other than that I don’t see a difference. The difference between 14.0.1 & 14.1.0 was a missing symbol in They’re supposed to run on |
Yes, this is the same situation we are seeing in recently opened PRs. What I see is that in our self-build the linking fails, and that in the test suite, stdout seems to be silenced, so we only get either empty output or stderr output. I've not yet tried to diagnose further, I'm a bit overloaded at the moment. |
About the linker error, people here are mentioning an Xcode bug that is being worked on by Apple. Workaround would be to downgrade to Xcode 13.4. Could the other issues, the testsuite ones be related to gnatW8? |
Or to upgrade to 14.1 (this is the current release: the 14.0 version was the one with the problem that I came across to do with exception handling). I think it may be possible to change to 14.1, but we’d have to fix on macos-12 rather than macos-latest? Some older discussions here.
I had an issue; |
I think we may have a way ahead. This run failed because of a change I made to "fix" a problem I saw in misc/local-reject-origin (is it |
I am doing a run on |
This patch:
if it ends up running on macos-12 chooses Xcode 14.1, on macos-11 it chooses Xcode 13.2.1. In both cases the tests run without the massive set of errors we’ve been seeing. (you’ll note I’ve added How to proceed? (particularly with the maxim-lobanov action). |
My preference would be to go to macos-10.15 and avoid introducing an external action. @mosteo do you have an opinion? |
I think this would be a bad idea because 10.15 will be unsupported from 1 December. Nothing wrong with macos-11, is there? it’s just the chance of getting macos-12 with the bad Xcode that’s worrying.
|
Normally I would also prefer an older release than an external action, but if the unsupporting is going to catch up to us soon, I guess for a while until the bug is fixed is OK to use it. |
This had fallen through the cracks, sorry. |
Reason: the git in macOS Xcode 14 defaults the initial branch to 'main', but the tests assume 'master'.