Speed-up search of incomplete solutions #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now avoid earlier the solving of a dependency which has been already seen in the search branch. We also had a bug that was duplicating the search space with every extra dependency. That meant an exponential increase in time for every extra dependency. Fortunately, this only affected incomplete solutions. In practice there are no visible changes as the solutions found are ultimately the same.
Fabien-Chouteau
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better pruning of the search space by discarding some branches earlier.
We also had a bug that was duplicating the search space with every extra dependency. That meant an exponential increase in time for every extra dependency. Fortunately, this only affected incomplete solutions.
In practice there are no visible changes as the solutions found are ultimately the same. There are some tweaks to informative messages to give a bit more of context to the user and report times.