💫CHANGED💫 Now using swift's argument parser for CLI #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now remove the first argument (the program argument) as argparse expects - Removed the isTerm checks as argparse does this internally - Added a do catch for possible errors thrown by the cli correctly - Set up dependencies correctly - Calling using parseasroot to catch all cases
|
Hey, what's up Miles, thanks for doing this! |
|
Okay!! Thank you so much for working with me again, don't be afraid to ask any questions you have about my code as/if problems arise. I'll be around for maintenance ;) |
|
Sounds good. Just fyi, I went ahead and removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks so much Alin for being so willing to work with me in PM's to help me figure out the complexities of Xcode development! I've managed to figure everything out now, and this encapsulates a completely new CLI interface for PearCleaner, one that leverages the ArgumentParser library to the highest degree and allows for a much more maintainable CLI module.
Some notes: