Skip to content

UI improvements in the Viewer2D and ImageGallery #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 10, 2020
Merged

UI improvements in the Viewer2D and ImageGallery #823

merged 19 commits into from
Mar 10, 2020

Conversation

fabiencastan
Copy link
Member

Description

Multiple UI improvements in the Viewer2D and ImageGallery

Features list

  • Viewer2D: more visible button to enable HDR viewer
  • Viewer2D: add alpha background option
  • ImageGallery: allow to visualize the list of HDR images created by LDRToHDR
  • Add "New Pipeline" submenu
  • Add Open Recent Project
  • AttributeEditor: improve display of long floating point values
  • GraphEditor: more visible refresh nodes status button

Implementation remarks

  • Viewer2D: avoid error on empty metadata
  • Viewer2D: refactoring to simplify layouts
  • fix multiple QML warnings due to invalid properties

@fabiencastan
[ui] AttributeEditor: improve display of long floating point values
77fc562
@fabiencastan
[ui] Viewer2D: simplify naming
ac82890 
Conflicts:
	meshroom/ui/qml/Viewer/Viewer2D.qml
@fabiencastan
[ui] Viewer2D: avoid error on empty metadata
c9c24b7
@fabiencastan
[ui] Viewer2D: refactoring to simplify layouts
d70c625 
* fix mousearea order
* add alpha backgroud
* move HDR as a tool button

Conflicts:
	meshroom/ui/qml/Viewer/CircleGizmo.qml
	meshroom/ui/qml/Viewer/Viewer2D.qml
@fabiencastan
[ui] Viewer2D: minor adjustments
540c0d1 
* more explicit variable name for hdrImageToolbar
* adjust padding, so the viewer2D.bottomToolbar is aligned with the
ImageGallery toolbar
* update tooltip for HDR image viewer
@fabiencastan
[ui] Viewer2D: if imageType is disabled switch back to "image" type
eae0f4b
@fabiencastan
[ui] fix warnings for undefined _reconstruction.graph
7d0f1ec
@fabiencastan
[ui] GraphEditor: more visible refresh nodes status button
f34397c
@fabiencastan
[nodes] LDRToHDR: export sfmData as json (.sfm instead of .abc)
e0b25a8 
No need for binary file format, it only contains views with image paths
and resolved metadata.
@fabiencastan
[ui] Viewer2D: improve toolbar alignment/spacing
c9061f3 
Conflicts:
	meshroom/ui/qml/Viewer/Viewer2D.qml
@fabiencastan
[ui] add "New Pipeline" submenu
089289b
@fabiencastan
[ui] ImageGallery: add button to reset thumbnails size to default value
5f2cef7
@fabiencastan
[ui] Viewer2D: add MouseArea on zoom item
85dd992 
* reset zoom to fit image on left click
* right click menu
@fabiencastan
[ui] ImageGallery: allow to visualize the list of HDR images created …
19d2f90 
…by LDRToHDR

Conflicts:
	meshroom/ui/reconstruction.py
@fabiencastan
[ui] Viewer2D: change min value of gamma in HDR Image Toolbar
57e867d
@fabiencastan
[ui] Viewer2D: rename ImageToolbar into HdrImageToolbar
1fb1304
@fabiencastan
[ui] fix qml warnings when there is no metadata on input images
d1ab458
@fabiencastan
[ui] add Open Recent Project
d001cc9
@fabiencastan
[ui] qml warning fix by using directly the edge object instead of the…
76fd327 
… property
@fabiencastan fabiencastan requested a review from yann-lty March 10, 2020 12:00
@fabiencastan fabiencastan added this to the Meshroom 2020.1.0 milestone Mar 10, 2020
@fabiencastan fabiencastan merged commit 2381cde into develop Mar 10, 2020
@fabiencastan fabiencastan deleted the dev/hdrImageViewer branch March 10, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann-lty yann-lty Awaiting requested review from yann-lty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Meshroom 2020.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@fabiencastan