Skip to content

[core] GroupAttribute: check "enabled" property of child params in uid computation #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

[core] GroupAttribute: check "enabled" property of child params in uid computation #1027

merged 1 commit into from
Aug 11, 2020

Conversation

fabiencastan
Copy link
Member

@fabiencastan fabiencastan commented Aug 11, 2020 •
edited
Loading

Disabled params should not be part of the UID computation, even for child attributes of an enabled GroupAttribute.

For instance, on the ImageProcessing node:

  • Note the original "Output Folder"
  • Enable "Sharpen Filter"
  • Change "Width"
  • Disable "Sharpen Filter"
  • Should get the same value as the original "Output Folder" (even if the disabled "Sharpen Width" is not the same)

Improve PR #1007

@fabiencastan
[core] GroupAttribute: check "enabled" property of child params in ui…
588c2e5 
…d computation

Disabled params should not be part of the UID computation, even for child attributes of an enabled GroupAttribute.
@fabiencastan fabiencastan added this to the Meshroom 2020.1.0 milestone Aug 11, 2020
@fabiencastan fabiencastan requested a review from hdgnd August 11, 2020 09:51
@fabiencastan fabiencastan merged commit 20fa43c into develop Aug 11, 2020
@fabiencastan fabiencastan deleted the fix/enabledPropertyInGroupAttributes branch August 11, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdgnd hdgnd hdgnd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Meshroom 2020.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fabiencastan @hdgnd