[depthMap] fix crash if no nearby camera #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o T camera The function do not deal with files anymore and the early-exit condition has not been updated. So instead of creating the output file in this early-exit condition, we initialize the output.
gregoire-dl
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix alicevision/Meshroom#409
A bug on depth map computation has been introduced in AliceVision-2.1.0 release (corresponding to Meshroom-2019.1).
This problem only happens when badly connected cameras have been reconstructed in the SfM.
Implementation remarks
The function "refinerc" do not deal with files anymore. The file manipulation has been moved to a more high-level function. Unfortunately, one early-exit condition has not been updated during this refactoring. This PR fixes this mistake.