Skip to content

Ability to load depth maps into 2D and 3D Viewers within meshroom #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 27, 2020
Merged

Ability to load depth maps into 2D and 3D Viewers within meshroom #769

merged 15 commits into from
Jan 27, 2020

Conversation

fabiencastan
Copy link
Member

@fabiencastan fabiencastan commented Jan 24, 2020 •
edited
Loading

New PR based on #657 (with a rebase to clean old merge commits).

@fabiencastan fabiencastan requested a review from yann-lty January 24, 2020 12:11
@fabiencastan fabiencastan added this to the Meshroom 2020.1.0 milestone Jan 24, 2020
@fabiencastan fabiencastan force-pushed the ChemicalXandco-view_depthmaps2 branch 2 times, most recently from f7e36ff to 0dfc80a Compare January 27, 2020 12:15
ChemicalXandco and others added 15 commits January 27, 2020 13:16
@ChemicalXandco @fabiencastan
[ui] Reconstruction: add 'depthMap' member
978f4a9
@ChemicalXandco @fabiencastan
add ComboBox to select depth map file
5652770
@ChemicalXandco @fabiencastan
add button on 2D Viewer to view depth maps in the 3D Viewer
b2db142
@ChemicalXandco @fabiencastan
use getImageFile function to set image source
4ddd25f
@ChemicalXandco @fabiencastan
use Filepath.stringToUrl instead of "file:///"+
5c279f3
@fabiencastan
[ui] viewer: move depthmap to 3D to the right and remove "Map" from c…
7bea135 
…ombobox
@fabiencastan
[ui] reset depthmap node when camerainit change
a37ecc1
@fabiencastan
[ui] minor qml warning fix
c38f0c3
@fabiencastan
[ui] Viewer: use label for DepthMap node instead of name
8fd7071
@fabiencastan
remove trailing comments
9c70ce5
@fabiencastan
[ui] Viewer: use flat combobox for better integration in the Viewer
fcdb372
@fabiencastan
[ui] Viewer: use RowLayout instead of manual relative sizes
dabf19d
@fabiencastan
[ui] Viewer: update min values
18ab1d1
@fabiencastan
[ui] Viewer2D: minor warning fixes
9bcad1c
@fabiencastan
[core] more precise warning on plugins load failure
0dfc80a
@fabiencastan fabiencastan merged commit e5b9509 into develop Jan 27, 2020
@fabiencastan fabiencastan deleted the ChemicalXandco-view_depthmaps2 branch January 27, 2020 15:04
@fabiencastan fabiencastan mentioned this pull request Jan 27, 2020
Closed
@natowi natowi mentioned this pull request Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann-lty yann-lty Awaiting requested review from yann-lty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Meshroom 2020.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fabiencastan @ChemicalXandco