-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New local isolated computation for python nodes #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ronment configuration
- add option to control verbosity - in extern mode: disable logging and enable it only for the node computation (to avoid polluting the node's log with general warnings)
…oom_compute Reoganization - BaseNode: is the base class for all nodes - Node: is now dedicated to python nodes, with the implentation directly in the process function - CommandLineNode: dedicated to generate and run external command lines
Avoid qml errors when accessing non-existing nodes. The entry exist in the dict and we retrieve a null node.
0ee1757
to
426855b
Compare
Avoid an ambiguous LOCAL_ISOLATED, as a process can be extern and using an isolated execution environement.
And add the check about duplicates for canBeStopped/canBeCanceled.
39b48cc
to
346d78d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 20 out of 23 changed files in this pull request and generated 2 comments.
Files not reviewed (3)
- meshroom/ui/qml/Application.qml: Language not supported
- meshroom/ui/qml/GraphEditor/GraphEditor.qml: Language not supported
- meshroom/ui/qml/GraphEditor/Node.qml: Language not supported
Comments suppressed due to low confidence (3)
meshroom/submitters/rippleSubmitter.py:1
- Ensure that the removal of rippleSubmitter.py is intentional and verify that there are no remaining dependencies on this module.
Entire file removed
meshroom/core/graph.py:1384
- Reassigning cacheDir to an empty string may bypass the intended default cache folder behavior; please verify that this change is deliberate.
self.cacheDir = ""
meshroom/core/nodeFactory.py:171
- [nitpick] Consider resolving or documenting the potential naming conflicts between user-defined inputs/outputs and internal names to avoid ambiguity.
# TODO: user inputs/outputs may conflicts with internal names (like position, uid)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cb15a0b
to
2ad5535
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #2703 +/- ##
===========================================
- Coverage 79.01% 76.75% -2.27%
===========================================
Files 39 40 +1
Lines 5809 6082 +273
===========================================
+ Hits 4590 4668 +78
- Misses 1219 1414 +195 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
"isComputable" is renamed as "isComputableType": this function is only about the Meshroom Node type and not about the computability in the current context. Even if we are in compatibility mode, we may has access to the nodeDesc and its information about the node type.
When the compatibility node was fully computed, the recompute/resubmit button was available in the UI menu. The reason is that we need to propagate that the connected nodes can be computed if there is a compatibility node in the dependency iff it is already fully computed. Now there is an additional explicit check.
The states of nodes were not valid the first time they were loaded, but became valid after any topological update (such as creating or removing a node or edge). The reason was that the loading of the graph was done before setting the project path (and thus the cacheDir). So the status files of the nodes were not available during the graph creation and were not updated at the end of the load. Now we set the filepath/cache first, so everything is right from the start.
d25b830
to
f8567fb
Compare
New notion of local isolated computation for python nodes using meshroom_compute.
Reorganization