Fix: Improve large project file loading performance #2665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Slot Connecting the valueChanged signal to a lambda causes performance issues with a large number of attributes when using the Pyside backend. Connecting that signal to an intermediate Slot part of the Attribute class improves performance dramatically. Note: This has no comparable impact on the standalone backend.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2665 +/- ##
===========================================
+ Coverage 69.95% 69.96% +0.01%
===========================================
Files 122 122
Lines 7106 7109 +3
===========================================
+ Hits 4971 4974 +3
Misses 2135 2135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
servantftransperfect
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adresses performance issues when loading large project files (in UI mode), introduced as part of #2586.
It changes the way a Node is notified of an Attribute value change, which has a great impact on Attribute creation time.
The figures below shows the before and after for a project with a large number of attributes.
Before
Overall attribute creation time: 146s
After
Overall attribute creation time: 1.24s
Features list
Implementation remarks
The notification of attribute value change to the owning node has been reworked to use a Signal/Slot connection, rather than a Signal/lambda.
This leads to much better performance, while preserving the same behavior.