Skip to content

Create new pipeline for testing modular sfm #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 14, 2025
Merged

Create new pipeline for testing modular sfm #2664

merged 6 commits into from
Feb 14, 2025

Conversation

servantftransperfect
Copy link
Contributor

  • Create experimental pipelines templates for
  1. tracking
  2. tracking without calibration
  3. photogrammetry
  4. photogrammetry with tracking
  • Update meshroom to consider the new sfm Nodes as if it was the previous StructureFromMotion node

Requires alicevision/AliceVision#1818

@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.95%. Comparing base (910736b) to head (696ec16).
⚠️ Report is 420 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2664   +/-   ##
========================================
  Coverage    69.95%   69.95%           
========================================
  Files          122      122           
  Lines         7106     7106           
========================================
  Hits          4971     4971           
  Misses        2135     2135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mh0g mh0g self-requested a review February 13, 2025 14:03
mh0g
mh0g approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@mh0g mh0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the camera tracking pipeline vs the original camera tracking on sequ 035 of anna.
After aligning the two set of poses, quantitatively the difference was extremely small for the average center distance and rotation angles:
image

@mh0g mh0g merged commit ff921d6 into develop Feb 14, 2025
5 checks passed
@mh0g mh0g deleted the dev/changeDefaultSfm branch February 14, 2025 08:04
@cbentejac cbentejac added this to the Meshroom 2025.1.0 milestone Feb 17, 2025
@fabiencastan fabiencastan added the feature new feature (proposed as PR or issue planned by dev) label Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mh0g mh0g mh0g approved these changes

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

Assignees
No one assigned
Labels
feature new feature (proposed as PR or issue planned by dev) prio:critical
Projects
None yet
Milestone
Meshroom 2025.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@servantftransperfect @mh0g @fabiencastan @cbentejac