Skip to content

[ui] Viewer2D: Display lighting circle with auto detected sphere #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2024
Merged

[ui] Viewer2D: Display lighting circle with auto detected sphere #2413

merged 2 commits into from
May 27, 2024

Conversation

gregoire-dl
Copy link
Member

Description

Add posibility to display auto detected spheres from a SphereDetection node.

Features list

  • Change displayLightingCircleLoader icon to avoid confusion with displayFisheyeCircleLoader.
  • Load and display from Json auto detected spheres.

@gregoire-dl gregoire-dl self-assigned this May 26, 2024
@fabiencastan fabiencastan added this to the Meshroom 2024.1.0 milestone May 27, 2024
@fabiencastan fabiencastan added the feature new feature (proposed as PR or issue planned by dev) label May 27, 2024
@fabiencastan fabiencastan merged commit e445fb2 into develop May 27, 2024
@fabiencastan fabiencastan deleted the dev/sphereDetectionAutoDetection branch May 27, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

@cbentejac cbentejac Awaiting requested review from cbentejac

Assignees

@gregoire-dl gregoire-dl

Labels
feature new feature (proposed as PR or issue planned by dev) review type:enhancement
Projects
None yet
Milestone
Meshroom 2025.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gregoire-dl @fabiencastan