Skip to content

[core/ui] Load image sequence from node's output in SequencePlayer #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 20, 2024
Merged

[core/ui] Load image sequence from node's output in SequencePlayer #2375

merged 13 commits into from
Jun 20, 2024

Conversation

Just-Kiel
Copy link
Contributor

@Just-Kiel Just-Kiel commented Apr 16, 2024 •
edited
Loading

  • Image sequence is detected because the semantic of the output is defined as "sequence" in the description of the node

  • SequencePlayer is enabled when double-clicked on the node

  • Need to set the path for the image sequence is : /path/to/define/<FRAMEID>.extension

  • Unsync of Viewers and SequencePlayer when displayed output is sequence output

@Just-Kiel Just-Kiel added the UI label Apr 16, 2024
@Just-Kiel Just-Kiel self-assigned this Apr 16, 2024
@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch from fd90bb5 to 9faaab2 Compare April 16, 2024 16:10
@Just-Kiel Just-Kiel added the feature new feature (proposed as PR or issue planned by dev) label Apr 17, 2024
@Just-Kiel Just-Kiel added this to the Meshroom 2024.1.0 milestone Apr 17, 2024
cbentejac
cbentejac previously requested changes Apr 20, 2024
View reviewed changes
@cbentejac cbentejac marked this pull request as draft April 20, 2024 14:46
@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch from ba89665 to e50715d Compare April 23, 2024 13:42
@Just-Kiel Just-Kiel marked this pull request as ready for review April 23, 2024 13:43
fabiencastan
fabiencastan reviewed May 13, 2024
View reviewed changes
@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch from e50715d to 1360d56 Compare May 13, 2024 08:55
@Just-Kiel Just-Kiel requested a review from fabiencastan May 13, 2024 08:55
@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch from 1360d56 to 850b0f9 Compare May 14, 2024 12:40
fabiencastan
fabiencastan reviewed May 17, 2024
View reviewed changes
fabiencastan
fabiencastan reviewed May 17, 2024
View reviewed changes
@Just-Kiel Just-Kiel requested a review from fabiencastan May 21, 2024 15:20
fabiencastan
fabiencastan reviewed May 21, 2024
View reviewed changes
@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch from 30d5eba to bfd7b1d Compare May 22, 2024 14:28
@Just-Kiel Just-Kiel requested a review from fabiencastan May 23, 2024 09:05
@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch from 03f7d5c to 049d766 Compare June 6, 2024 11:51
fabiencastan
fabiencastan reviewed Jun 7, 2024
View reviewed changes
@fabiencastan
Copy link
Member

Need to update requirements with the new dependency.

@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch from 049d766 to 014276b Compare June 7, 2024 09:11
@Just-Kiel Just-Kiel requested a review from fabiencastan June 7, 2024 09:13
@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch from d21be1e to dc93258 Compare June 10, 2024 12:49
@fcastan fcastan force-pushed the dev/sequenceFromOutput branch from dc93258 to fd76839 Compare June 16, 2024 22:03
@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch 3 times, most recently from 1766e62 to 4d0bae4 Compare June 19, 2024 16:22
@Just-Kiel Just-Kiel changed the base branch from develop to dev/integrateSequencePlayer June 19, 2024 16:24
@Just-Kiel Just-Kiel changed the base branch from dev/integrateSequencePlayer to develop June 19, 2024 16:25
Just-Kiel added 13 commits June 20, 2024 11:54
@Just-Kiel
[core] Add detection of sequence semantic output
3eb9032
@Just-Kiel
[ui] Load image sequence from node output in SequencePlayer
b0063b0
@Just-Kiel
[Viewer] Fix of side effects from output sequence in SequencePlayer
6e89cb6 
Unsync 3D Viewer and SequencePlayer if it is output sequence and set to 0 the frame displayed when changing sequence
@Just-Kiel
[core] Add support for imageList as output in SequencePlayer
7af0997
@Just-Kiel
[ui] Support for imageList and sequence in SequencePlayer
4590868
@Just-Kiel
[ui] Resolve Sequence and ImageList on Python side
1168cca
@Just-Kiel
[ui] Use of pyseq for getting sequences
cc20995 
[ui] To squash
@Just-Kiel
Add pyseq to requirements.txt
f4404f2
@Just-Kiel
[core] Prevent bug from onAttributeChanged when setting value of self…
aacacb1 
… attribute
@Just-Kiel
[ui] Eye displayed for node with sequence output
9acc0a7
@Just-Kiel
[ui] Timer not displayed on node not computable
8935ded
@Just-Kiel
[ui] Sequence with missing files displayable and switching if display…
d738f4a 
…ed attribute changed
@Just-Kiel
[ui] Removal of getAttributeByName in Viewer2D
5a8ceaf
@Just-Kiel Just-Kiel force-pushed the dev/sequenceFromOutput branch from 4d0bae4 to 5a8ceaf Compare June 20, 2024 09:55
@fabiencastan fabiencastan merged commit b577b87 into develop Jun 20, 2024
@fabiencastan fabiencastan deleted the dev/sequenceFromOutput branch June 20, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

@demoulinv demoulinv Awaiting requested review from demoulinv

@cbentejac cbentejac Awaiting requested review from cbentejac

@servantftransperfect servantftransperfect Awaiting requested review from servantftransperfect

Assignees

@Just-Kiel Just-Kiel

Labels
feature new feature (proposed as PR or issue planned by dev) UI
Projects
None yet
Milestone
Meshroom 2025.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Just-Kiel @fabiencastan @cbentejac