New InputNode for nodes without computation and support for all param types in output (and no more limited to File type) #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
706e6fe to
6b9cf7b
Compare
cbentejac
previously requested changes
Apr 20, 2024
There was a problem hiding this comment.
Tested, works well, and the whole implementation is clean.
Tiny cosmetic changes to do, and see if we can come up with something that's less oriented than "InputNode" for the class' name.
It would also be good to add the upgrade of these nodes in the tests (https://github.com/alicevision/Meshroom/blob/develop/tests/test_compatibility.py).
ff4d951 to
88b6dbe
Compare
9b4eebe to
e45418c
Compare
When computing or submitting a graph, if nodes are not computable they do not send warning that nodes had trouble.
… node computable or not
e45418c to
d2ad818
Compare
fabiencastan
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node without computation implemented with creation of InputNode class for easy description of Node.
Also changes for UI :