[ui] node time computation and chunks count in node editor header #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
previously requested changes
Jan 22, 2023
cbentejac
previously requested changes
Jan 25, 2023
There was a problem hiding this comment.
If you select a node, start its computations, and wait without unselecting it, the timer never stops if the status is updated to ERROR: the displayed computation time keeps on increasing as the timer keeps on being triggered.
If you unselect the node, the timer is immediately stopped, and if you reselect it, the displayed computation time is correct.
I don't know where it happens, but it seems like the globalStatusChanged signal is not emitted when the node's status changes to ERROR.
On another note, since we compute the elapsedTime when we stop the computations (cf the except clauses in node.py), couldn't we display it in that case as well? (it is an open question)
3c4d923 to
46cee68
Compare
46cee68 to
2057ffd
Compare
ac04639 to
a6e56cf
Compare
a6e56cf to
1eb714f
Compare
[ui] add node computation time in real time in node editor [ui] add node computation time in real time in node editor
…tation, function naming
1eb714f to
606e8e2
Compare
fabiencastan
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvement of computation information in node editor header
Features list
[X] update computation time every 2.5 seconds in header
[X] computation time when error occurs
[X] chunk computed counter in node editor header
Implementation remarks
The previous label text logic is moved to the nodeChanged signal because the logic is overwritten by the timer when setting the text time.
I don't know if 2.5 seconds is the best choice, feel free to give other refresh timing ideas.