Skip to content

make the IP input box in Listening Query be required.(#13234) #13235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

chunhai1127
Copy link
Contributor

make the IP input box in Listening Query be required

Copy link

github-actions bot commented Apr 8, 2025

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@KiteSoar
Copy link
Collaborator

KiteSoar commented Apr 8, 2025

@chunhai1127 合并代码需要签一下CIA~

@chunhai1127
Copy link
Contributor Author

CIA是什么,要怎么签

@KiteSoar
Copy link
Collaborator

KiteSoar commented Apr 9, 2025

CIA是什么,要怎么签

现在已经CIA签完了,但是CI没过,需要修一下

@chunhai1127
Copy link
Contributor Author

只修改了前端代码,CI不应该不通过的

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.33%. Comparing base (89055d4) to head (3ffa9e5).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13235      +/-   ##
=============================================
+ Coverage      72.32%   72.33%   +0.01%     
  Complexity     10062    10062              
=============================================
  Files           1313     1313              
  Lines          42240    42240              
  Branches        4433     4433              
=============================================
+ Hits           30551    30556       +5     
+ Misses          9582     9574       -8     
- Partials        2107     2110       +3     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89055d4...3ffa9e5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wuyfee
Copy link

wuyfee commented Apr 14, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion merged commit b64c8cb into alibaba:develop Apr 21, 2025
8 of 9 checks passed
@KomachiSion KomachiSion linked an issue Apr 21, 2025 that may be closed by this pull request
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Nacos console Related to Nacos consle labels Apr 21, 2025
@KomachiSion KomachiSion added this to the 2.5.2 milestone Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

监听查询维度是IP时,IP输入框应该必填
6 participants