Skip to content

add tls protected field to connection meta #13122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

shiyiyue1102
Copy link
Collaborator

What is the purpose of the change

add tls protected field to connection meta

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.32%. Comparing base (502b08b) to head (ae4a175).

Files with missing lines Patch % Lines
.../core/remote/grpc/GrpcBiStreamRequestAcceptor.java 10.00% 9 Missing ⚠️
.../com/alibaba/nacos/core/remote/ConnectionMeta.java 25.00% 3 Missing ⚠️
.../negotiator/tls/OptionalTlsProtocolNegotiator.java 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13122      +/-   ##
=============================================
- Coverage      72.33%   72.32%   -0.01%     
+ Complexity     10036    10035       -1     
=============================================
  Files           1310     1310              
  Lines          42012    42018       +6     
  Branches        4412     4414       +2     
=============================================
+ Hits           30389    30391       +2     
- Misses          9516     9526      +10     
+ Partials        2107     2101       -6     
Files with missing lines Coverage Δ
.../com/alibaba/nacos/core/remote/ConnectionMeta.java 43.42% <25.00%> (-3.81%) ⬇️
.../negotiator/tls/OptionalTlsProtocolNegotiator.java 13.15% <0.00%> (-1.13%) ⬇️
.../core/remote/grpc/GrpcBiStreamRequestAcceptor.java 30.68% <10.00%> (-4.15%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502b08b...ae4a175. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Feb 19, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion merged commit da975ca into develop Feb 20, 2025
8 checks passed
@KomachiSion KomachiSion added this to the 2.5.1 milestone Feb 20, 2025
@KomachiSion KomachiSion deleted the develop-add-tlsflag-meta branch April 25, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants