Skip to content

develop-optimize-table #13119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

develop-optimize-table #13119

merged 2 commits into from
Feb 20, 2025

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

delete beta & tag table，support start without those two table for a pure new server.

@github-actions GitHub Actions
Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.36735% with 40 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (502b08b) to head (e93517b).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
.../server/service/ConfigGrayModelMigrateService.java 2.43% 40 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13119      +/-   ##
=============================================
- Coverage      72.33%   72.30%   -0.03%     
+ Complexity     10036    10033       -3     
=============================================
  Files           1310     1310              
  Lines          42012    42010       -2     
  Branches        4412     4414       +2     
=============================================
- Hits           30389    30376      -13     
- Misses          9516     9536      +20     
+ Partials        2107     2098       -9
Files with missing lines Coverage Δ
...cos/config/server/controller/ConfigController.java 69.07% <100.00%> (-0.37%) ⬇️
.../config/server/service/ConfigOperationService.java 79.13% <100.00%> (+4.30%) ⬆️
.../server/service/ConfigGrayModelMigrateService.java 0.64% <2.43%> (+0.64%) ⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502b08b...e93517b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wuyfee
Copy link

wuyfee commented Feb 18, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KiteSoar KiteSoar mentioned this pull request Feb 19, 2025
Merged
5 tasks
@KomachiSion KomachiSion merged commit 1e889ea into develop Feb 20, 2025
7 checks passed
@KomachiSion KomachiSion added this to the 2.5.1 milestone Feb 20, 2025
Jevgens added a commit to Jevgens/nacos that referenced this pull request Feb 20, 2025
@Jevgens
Revert "develop-optimize-table (alibaba#13119)"
3c3008d 
This reverts commit 1e889ea.
@Jevgens Jevgens mentioned this pull request Feb 20, 2025
Closed
@misakacoder misakacoder mentioned this pull request Mar 19, 2025
Merged
5 tasks
@KomachiSion KomachiSion deleted the develop-optimize-table branch April 25, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

@li-xiao-shuang li-xiao-shuang Awaiting requested review from li-xiao-shuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@shiyiyue1102 @codecov-commenter @wuyfee @KomachiSion