Skip to content

[ISSUE #13106] Should resetConfig() in the constructor of TopNConfig.java #13107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2025
Merged

[ISSUE #13106] Should resetConfig() in the constructor of TopNConfig.java #13107

merged 1 commit into from
Feb 14, 2025

Conversation

MajorHe1
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix #13106

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@github-actions GitHub Actions
Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

@wuyfee
Copy link

wuyfee commented Feb 13, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.33%. Comparing base (12c455b) to head (65d0d97).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13107      +/-   ##
=============================================
+ Coverage      72.30%   72.33%   +0.02%     
- Complexity     10022    10036      +14     
=============================================
  Files           1310     1310              
  Lines          42011    42012       +1     
  Branches        4412     4412              
=============================================
+ Hits           30375    30388      +13     
+ Misses          9531     9519      -12     
  Partials        2105     2105
Files with missing lines Coverage Δ
...om/alibaba/nacos/core/monitor/topn/TopNConfig.java 86.66% <100.00%> (+0.95%) ⬆️

... and 30 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c455b...65d0d97. Read the comment docs.

@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Nacos Core labels Feb 14, 2025
@KomachiSion KomachiSion added this to the 2.5.1 milestone Feb 14, 2025
@KomachiSion KomachiSion merged commit 502b08b into alibaba:develop Feb 14, 2025
8 checks passed
@MajorHe1 MajorHe1 deleted the MajorHe1-patch-1 branch February 14, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
area/Nacos Core kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

Should resetConfig() in the constructor of TopNConfig.java
4 participants
@MajorHe1 @wuyfee @codecov-commenter @KomachiSion