Skip to content

[ISSUE#13129] Optimize SDK connection parameter settings. #13145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2025
Merged

[ISSUE#13129] Optimize SDK connection parameter settings. #13145

merged 2 commits into from
Mar 3, 2025

Conversation

KiteSoar
Copy link
Collaborator

@KiteSoar KiteSoar commented Mar 1, 2025 •
edited
Loading

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

its for #13129

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.14%. Comparing base (88f6514) to head (a418a97).

Files with missing lines Patch % Lines
...a/nacos/common/remote/client/RpcClientFactory.java 66.66% 1 Missing and 1 partial ⚠️
...s/common/remote/client/RpcClientConfigFactory.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13145      +/-   ##
=============================================
- Coverage      72.16%   72.14%   -0.03%     
- Complexity     10015    10017       +2     
=============================================
  Files           1310     1311       +1     
  Lines          42029    42036       +7     
  Branches        4417     4418       +1     
=============================================
- Hits           30330    30326       -4     
- Misses          9611     9620       +9     
- Partials        2088     2090       +2
Files with missing lines Coverage Δ
...alibaba/nacos/client/config/impl/ClientWorker.java 76.89% <100.00%> (ø)
...ient/naming/remote/gprc/NamingGrpcClientProxy.java 98.35% <100.00%> (+<0.01%) ⬆️
...on/remote/client/grpc/DefaultGrpcClientConfig.java 99.32% <100.00%> (+1.25%) ⬆️
...s/common/remote/client/RpcClientConfigFactory.java 85.71% <85.71%> (ø)
...a/nacos/common/remote/client/RpcClientFactory.java 87.09% <66.66%> (-4.91%) ⬇️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f6514...a418a97. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Mar 1, 2025

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
❌ - e2e-go-test (standalone & cluster): failure
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KiteSoar
Copy link
Collaborator Author

KiteSoar commented Mar 1, 2025

PR related to docs
nacos-group/nacos-group.github.io#873

@KomachiSion KomachiSion merged commit f257fca into alibaba:develop Mar 3, 2025
7 checks passed
@KomachiSion KomachiSion added this to the 2.5.1 milestone Mar 3, 2025
@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. labels Mar 3, 2025
@KiteSoar KiteSoar deleted the develop-grpc-client-params branch March 3, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@KiteSoar @codecov-commenter @wuyfee @KomachiSion