Skip to content

[ISSUE#13090] Compatible with v2 openapi to query configuration. #13091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2025
Merged

[ISSUE#13090] Compatible with v2 openapi to query configuration. #13091

merged 2 commits into from
Feb 10, 2025

Conversation

KiteSoar
Copy link
Collaborator

@KiteSoar KiteSoar commented Feb 8, 2025

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

it is related to #13090

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.27%. Comparing base (3f636bf) to head (229f009).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13091      +/-   ##
=============================================
- Coverage      72.29%   72.27%   -0.02%     
- Complexity     10020    10022       +2     
=============================================
  Files           1310     1310              
  Lines          42008    42008              
  Branches        4411     4412       +1     
=============================================
- Hits           30370    30362       -8     
- Misses          9532     9541       +9     
+ Partials        2106     2105       -1
Files with missing lines Coverage Δ
...er/service/query/DefaultChainRequestExtractor.java 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f636bf...229f009. Read the comment docs.

@KomachiSion KomachiSion linked an issue Feb 10, 2025 that may be closed by this pull request
参考官网open api的“获取配置”的api接口时，只有获取public命名空间能成功，其他自建的命名空间都返回20004 #13090
Closed
@KomachiSion KomachiSion added area/Config kind/bug Category issues or prs related to bug. labels Feb 10, 2025
@KomachiSion KomachiSion added this to the 2.5.1 milestone Feb 10, 2025
@KomachiSion KomachiSion merged commit a13b64d into alibaba:develop Feb 10, 2025
6 of 7 checks passed
@KiteSoar KiteSoar deleted the Compatible-v2-openapi-to-get-config branch February 13, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

参考官网open api的“获取配置”的api接口时，只有获取public命名空间能成功，其他自建的命名空间都返回20004
3 participants
@KiteSoar @codecov-commenter @KomachiSion