Skip to content

[ISSUE #12823] Randomly generate TokenRefreshWindow #13046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

[ISSUE #12823] Randomly generate TokenRefreshWindow #13046

merged 1 commit into from
Jan 21, 2025

Conversation

lucky8987
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For issue#12823

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@lucky8987
[ISSUE alibaba#12823] Randomly generate TokenRefreshWindow, Avoid a l…
e18fc61 
…arge number of logins causing pressure on the Nacos server.
@github-actions GitHub Actions
Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base (2d78d1c) to head (e18fc61).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13046      +/-   ##
=============================================
- Coverage      72.32%   72.31%   -0.01%     
+ Complexity     10030    10027       -3     
=============================================
  Files           1310     1310              
  Lines          42004    42007       +3     
  Branches        4413     4413              
=============================================
- Hits           30378    30376       -2     
- Misses          9519     9522       +3     
- Partials        2107     2109       +2
Files with missing lines Coverage Δ
...s/client/auth/impl/NacosClientAuthServiceImpl.java 97.43% <100.00%> (+0.21%) ⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d78d1c...e18fc61. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Jan 16, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK area/plugin kind/enhancement Category issues or prs related to enhancement. labels Jan 21, 2025
@KomachiSion KomachiSion added this to the 2.5.1 milestone Jan 21, 2025
@KomachiSion KomachiSion merged commit b4d9642 into alibaba:develop Jan 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
area/Client Related to Nacos Client SDK area/plugin kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lucky8987 @codecov-commenter @wuyfee @KomachiSion