Skip to content

Conversation

Bo-Qiu
Copy link
Contributor

@Bo-Qiu Bo-Qiu commented Oct 29, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix(#12769 ): remove config history by derby.

Brief changelog

fix(#12769 ): remove config history by derby.

Verifying this change

fix(#12769 ): remove config history by derby.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.63%. Comparing base (4334cd1) to head (666289a).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12796      +/-   ##
=============================================
- Coverage      72.63%   72.63%   -0.01%     
+ Complexity      9804     9802       -2     
=============================================
  Files           1278     1278              
  Lines          41015    41015              
  Branches        4330     4330              
=============================================
- Hits           29793    29792       -1     
  Misses          9158     9158              
- Partials        2064     2065       +1     
Files with missing lines Coverage Δ
...rce/impl/derby/HistoryConfigInfoMapperByDerby.java 69.23% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4334cd1...666289a. Read the comment docs.

@wuyfee
Copy link

wuyfee commented Oct 29, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

@KomachiSion KomachiSion added this to the 2.5.0 milestone Oct 31, 2024
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Config labels Oct 31, 2024
@KomachiSion KomachiSion merged commit e2d44f2 into alibaba:develop Oct 31, 2024
8 checks passed
@Bo-Qiu Bo-Qiu deleted the fix/12769 branch November 4, 2024 06:52
lucky8987 pushed a commit to lucky8987/nacos that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【Bug Report】使用Derby数据库时,历史记录清理超过30天的历史时,会把近期的历史记录一起清除
4 participants