Skip to content

[ISSUE #12103] Enhance ClientWorker support grpc request timeout param. #12619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2024
Merged

[ISSUE #12103] Enhance ClientWorker support grpc request timeout param. #12619

merged 2 commits into from
Sep 18, 2024

Conversation

XiaZhouxx
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#12103

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@XiaZhouxx
Copy link
Contributor Author

@KomachiSion 幸苦大佬有空review一下

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.69%. Comparing base (3a9003b) to head (3458415).
Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
...alibaba/nacos/client/config/impl/ClientWorker.java 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12619      +/-   ##
=============================================
- Coverage      69.70%   69.69%   -0.01%     
- Complexity      9431     9433       +2     
=============================================
  Files           1275     1275              
  Lines          41232    41236       +4     
  Branches        4374     4375       +1     
=============================================
+ Hits           28740    28741       +1     
- Misses         10412    10415       +3     
  Partials        2080     2080
Files with missing lines Coverage Δ
...n/java/com/alibaba/nacos/api/PropertyKeyConst.java 0.00% <ø> (ø)
...alibaba/nacos/client/config/impl/ClientWorker.java 76.33% <83.33%> (+0.15%) ⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9003b...3458415. Read the comment docs.

@KomachiSion
Copy link
Collaborator

@XiaZhouxx https://github.com/nacos-group/nacos-group.github.io/blob/develop-astro-nacos/src/content/docs/next/zh-cn/manual/user/java-sdk/properties.md
辛苦在这个文档中添加一下新增的配置参数。

@KomachiSion KomachiSion merged commit 12f474e into alibaba:develop Sep 18, 2024
7 checks passed
@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. labels Sep 18, 2024
@KomachiSion KomachiSion added this to the 2.5.0 milestone Sep 18, 2024
@KomachiSion KomachiSion modified the milestones: 2.5.0, 2.4.3 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@XiaZhouxx @codecov-commenter @KomachiSion