Skip to content

Conversation

shiyiyue1102
Copy link
Collaborator

@shiyiyue1102 shiyiyue1102 commented Sep 18, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fixes #12625

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.68%. Comparing base (3a9003b) to head (e2a7e6b).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12659      +/-   ##
=============================================
- Coverage      69.70%   69.68%   -0.02%     
  Complexity      9431     9431              
=============================================
  Files           1275     1275              
  Lines          41232    41233       +1     
  Branches        4374     4374              
=============================================
- Hits           28740    28735       -5     
- Misses         10412    10419       +7     
+ Partials        2080     2079       -1     
Files with missing lines Coverage Δ
...fig/server/service/NamespaceConfigInfoService.java 100.00% <100.00%> (+9.09%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9003b...e2a7e6b. Read the comment docs.

@KomachiSion KomachiSion added this to the 2.5.0 milestone Sep 18, 2024
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/plugin labels Sep 18, 2024
@KomachiSion KomachiSion merged commit 91987b0 into alibaba:develop Sep 18, 2024
6 of 7 checks passed
@Hamdzadprst00
Copy link

چرا برای من فقط میزنه پندینگ هیچ حرکت درست انجام نمیده

Copy link

@Hamdzadprst00 Hamdzadprst00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

امیدوارم مشکلم حل بشه

@KomachiSion KomachiSion modified the milestones: 2.5.0, 2.4.3 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.4.2 创建命名空间失败/数据库语法问题
5 participants