Summer ospp#10389 #11208
Merged
Summer ospp#10389 #11208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please update the README to include explanations and instructions for the code changes. |
|
LGTM |
KomachiSion
requested changes
Oct 30, 2023
| @@ -157,7 +157,7 @@ nacos.core.config.plugin.fileformatcheck.enabled=false | |||
|
|
|||
| #*************** Istio Related Configurations ***************# | |||
| ### If turn on the MCP server: | |||
| nacos.istio.mcp.server.enabled=false | |||
| @@ -240,6 +240,23 @@ | |||
| </encoder> | |||
| </appender> | |||
|
|
|||
| <appender name="istio-main" | |||
There was a problem hiding this comment.
为什么要在core模块中添加这个日志内容？
| @@ -172,7 +172,7 @@ nacos.core.auth.plugin.nacos.token.secret.key= | |||
|
|
|||
| #*************** Istio Related Configurations ***************# | |||
| ### If turn on the MCP server: | |||
| nacos.istio.mcp.server.enabled=false | |||
| nacos.istio.mcp.server.enabled=true | |||
| @@ -28,8 +28,8 @@ | |||
| @Component | |||
| public class IstioConfig { | |||
|
|
|||
| @Value("${nacos.istio.mcp.server.enabled:false}") | |||
| private boolean serverEnabled = false; | |||
| @Value("${nacos.istio.mcp.server.enabled:true}") | |||
KomachiSion
approved these changes
Oct 30, 2023
KomachiSion
added a commit
that referenced
this pull request
Jul 23, 2024
* Summer ospp#10389 (#11208) * Notify IstioConfigChangeEvent by parsing config tags * Parse Configs and Create Virtual Service * function complete * Style Fixed * Delete Personal Info * add some comments and regex process func * Nacos Istio LDS & RDS xds protocol * reset configs * configTags is an optional parameters, fix istio force required problem. --------- Co-authored-by: PoisonGravity <rain_jwzhang@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LDS\RDS xDS protocol transmission functionality