Handle function literals and nested functions #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a function contains a nested function literal, we need to associate each return statement with the correct function. A naked return statement in the function literal may be okay if it has no named return values. To track state, we create a new visitor each time we enter a function or function literal.
bboozzoo
reviewed
Jan 23, 2020
|
Thanks for the fix guys, lgtm. Probably worthwhile to get some CI/unit tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a function contains a nested function literal, we need to associate each return statement with the correct function. A naked return statement in the function literal may be okay if it has no named return
values.
To track state, we create a new visitor each time we enter a function or function literal.
Fixes #11