-
-
Notifications
You must be signed in to change notification settings - Fork 147
Added auth0 prompt custom text #497
Added auth0 prompt custom text #497
Conversation
This is an attempt to add the prompt custom texts to the terraform resource. This is my first change to a terraform resource project, so any feedback is very welcome. The challenge that we have in the custom text is that they don't seem to have an ID (at least none is returned on the API). One way to create an ID is using the prompt type and the language. I used this to create the ID, but I am not sure what is default pattern is for this kind of situation. If you have any ideas for improvements or another way to do it, please provide feedback. PS: I have tested the code, either using the test and also using the compiled file and it works fine. |
@sergiughf We have been waiting for this feature since long. Can you please review this and merge and release if all looks okay to you? |
Hey folks, I'll take a look at this today. 🖖🏻 |
Quick update that I started taking a look at this but haven't yet finished running through all the manual tests I wanted to perform. I'll give another update later in the day. |
Hey @jluiz20, thanks a lot for the contribution! The PR was in a pretty good shape, I only pushed a couple of small improvements that we can go over together if you have any questions.
Your assumption is correct, the The only thing I feel is missing from this PR is to add functionality on the |
Hi @sergiughf. Thanks, very happy to contribute to the provider that I am using :D your suggestion about the missing reset for the body is good. I have already made the changes. Thank you for reviewing! |
@sergiughf, just added on more change, see if my thinking is right:
What I did was add the What do you think? |
Yeah that makes sense! Thanks @jluiz20! ⭐ I tested locally and everything seems to work, although could I ask you to please not ignore the error on the delete when you call |
of course. My bad for ignoring the error. I am pretty new to golang 😬 |
For being pretty new to golang you did a great job @jluiz20 🏆 Thanks a lot for the contribution, this is going to help a lot of folks! I'll merge this first thing in the morning. |
edded error Co-authored-by: Sergiu Ghitea <28300158+sergiughf@users.noreply.github.com>
d847966
to
d550a43
Compare
Hey @jluiz20 👋🏻 I added a new commit to improve the error handling on importing the custom text f017f3e and rebased to push the changelog for the new version. |
Proposed Changes
auth0_prompt_custom_text
Acceptance Test Output
Click to expand test output
Community Note