Skip to content
This repository was archived by the owner on Mar 8, 2022. It is now read-only.

Don't read back secrets as they are write-only #473

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Don't read back secrets as they are write-only #473

merged 3 commits into from
Nov 23, 2021

Conversation

alexkappa
Copy link
Owner

Proposed Changes

  • auth0_action: secrets are write-only and therefore never read back from the upstream API.

Fixes #472 #470

Acceptance Test Output

$ make testacc TESTS=TestAccAction                                                                                                                                                                                                         [14:22:35]
==> Checking that code complies with gofmt requirements...
?       github.com/alexkappa/terraform-provider-auth0   [no test files]
=== RUN   TestAccAction
--- PASS: TestAccAction (6.37s)
PASS
coverage: 7.9% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0     6.686s  coverage: 7.9% of statements
?       github.com/alexkappa/terraform-provider-auth0/auth0/internal/debug      [no test files]
?       github.com/alexkappa/terraform-provider-auth0/auth0/internal/digitalocean       [no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/hash       0.298s  coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/random     0.440s  coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/validation 0.532s  coverage: 0.0% of statements [no tests to run]
?       github.com/alexkappa/terraform-provider-auth0/version   [no test files]

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@alexkappa alexkappa merged commit 4aa5534 into master Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
resource/auth0_action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auth0_action: secrets are not deployed resulting on action not being deployed
1 participant
@alexkappa