Skip to content

fix example and make it valid JSON #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024

Conversation

Comradin
Copy link
Contributor

Fix the given JSON in the long command help text and show a valid
JSON document.

resolves #432

Copy link

derek bot commented Apr 14, 2024

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

Fix the given JSON in the long command help text and show a valid
JSON document.

resolves alexellis#432

Signed-off-by: Marcus Franke <marcus.franke@gmail.com>
@derek derek bot removed the no-dco label Apr 14, 2024
@Comradin
Copy link
Contributor Author

Comradin commented Apr 14, 2024

Thanks for the bot example with the amend and signoff syntax! this helped a lot.

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@alexellis alexellis merged commit 69f4cef into alexellis:master May 15, 2024
@Comradin Comradin deleted the fix/plan-example branch May 17, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long help string for plan command contains an error
2 participants